Skip to content

Conversation

malbarbo
Copy link
Contributor

This commits add an entry to travis matrix that will execute wasm32-unknown-emscripten tests suites.

malbarbo added 5 commits June 13, 2017 09:32
- rename emscripten docker image to asmjs
- create wasm32 docker image
Files with extensions .asm.js are used to generate .wasm files, they are
not intented to be execute.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@malbarbo
Copy link
Contributor Author

This is an alternative to #42059

@malbarbo
Copy link
Contributor Author

r? @alexcrichton

We are running out of builders... but testing wasm32 in the same builder of asmjs would take too much time.

@alexcrichton
Copy link
Member

Looks awesome, thanks for this! I think that the cwd business could be fixed as well with #42059, right?

Perhaps this could add a disabled/wasm/Dockerfile for now to land immediately and we could have a future PR to enable?

@malbarbo
Copy link
Contributor Author

malbarbo commented Jun 13, 2017

I think that the cwd business could be fixed as well with #42059, right?

I think so.

Perhaps this could add a disabled/wasm/Dockerfile for now to land immediately and we could have a future PR to enable?

Ok. Can we try this before to confirm it works on travis?

@alexcrichton
Copy link
Member

Sure yeah! Want to just tag it with ALLOW_PR=1 on this pr? That way the PR builds should run the travis build.

@arielb1 arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 13, 2017
@alexcrichton
Copy link
Member

Timeout :(

If you run ./src/ci/docker/run.sh wasm though that should be equivalent to Travis? (if that passes locally I'd be pretty confident it'd pass remotely)

@malbarbo
Copy link
Contributor Author

It passes locally. I will move the image to disabled.

@malbarbo
Copy link
Contributor Author

Done.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

📌 Commit 9da77b3 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 15, 2017

⌛ Testing commit 9da77b3 with merge 915b4ae...

@bors
Copy link
Collaborator

bors commented Jun 15, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member

@bors retry

Failure appears spurious, possibly git/network related #42117

@bors
Copy link
Collaborator

bors commented Jun 15, 2017

⌛ Testing commit 9da77b3 with merge 2057edf...

@bors
Copy link
Collaborator

bors commented Jun 15, 2017

💔 Test failed - status-travis

@est31
Copy link
Member

est31 commented Jun 15, 2017

@bors retry

  • spurious mac timeout

@alexcrichton
Copy link
Member

alexcrichton commented Jun 15, 2017 via email

@bors
Copy link
Collaborator

bors commented Jun 16, 2017

⌛ Testing commit 9da77b3 with merge c3627e2...

bors added a commit that referenced this pull request Jun 16, 2017
Add a travis builder for wasm32-unknown-emscripten

This commits add an entry to travis matrix that will execute wasm32-unknown-emscripten tests suites.

- Emscripten for asmjs was updated to sdk-1.37.13-64bit
- The tests are run with node 8.0.0 (it can execute wasm)
- A wrapper script is used to run each test from the directory where it is (workaround for emscripten-core/emscripten#4542)
- Some tests are ignore, see #42629 and #42630
@bors
Copy link
Collaborator

bors commented Jun 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c3627e2 to master...

@bors bors merged commit 9da77b3 into rust-lang:master Jun 16, 2017
@malbarbo malbarbo deleted the wasm32 branch October 25, 2017 16:38
@malbarbo malbarbo restored the wasm32 branch October 25, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants